feat(location-field): make location group order configurable #771
Conversation
| const OtherFeaturesHeader = () => ( | ||
| <S.MenuGroupHeader as={headingType} bgColor="#333" key="other-header"> | ||
| <FormattedMessage | ||
| description="Text for header above the 'other'" |
There was a problem hiding this comment.
Description looks unfinished, could you fix please?
…/otp-ui into reorder-other-to-first
|
Blocked by #774 |
amy-corson-ibigroup
added
the
BLOCKERS
amy-corson-ibigroup
removed
the
BLOCKERS
| const [otherControl, setOtherControl] = useState(false); | ||
| return ( | ||
| <> | ||
| <label htmlFor="other-input"> |
There was a problem hiding this comment.
Could you make Storybook create the controls using argTypes instead? (Storybook will add that to its "Controls" tab - I should have mentioned that in my previous review but somehow thought you knew) Do that for this story only. Refer to e.g.
amy-corson-ibigroup
requested review from
miles-grant-ibigroup
and removed request for
josh-willis-arcadis
| /** | ||
| * If true, make "Other" category (addresses, POIs, etc.) first in the results container. | ||
| */ | ||
| renderOtherFirst?: boolean; |
There was a problem hiding this comment.
Can we make this an array instead? Where we can manually set an order of categories to prioritize (and those will be displayed first). This might require a bigger refactor but I think it's worth it. Let me know if you'd like to discuss in more detail offline
There was a problem hiding this comment.
so like ["STOPS", "STATIONS", "OTHER"] as the config item?
Allows configuration of the order of the returned location group results, so that if you pass
renderOtherFirstthrough the config, it puts the "other" category first in the results, above stops and stations.